Skip to content

chore: Remove usage of paste crate#20946

Merged
comphead merged 5 commits intoapache:mainfrom
coderfender:deprecate_paste_module
Mar 16, 2026
Merged

chore: Remove usage of paste crate#20946
comphead merged 5 commits intoapache:mainfrom
coderfender:deprecate_paste_module

Conversation

@coderfender
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates core Core DataFusion crate functions Changes to functions implementation labels Mar 14, 2026
@coderfender
Copy link
Contributor Author

TODO : Deprecate paste crate usage in error.rs

@github-actions github-actions bot added the common Related to common crate label Mar 14, 2026
@coderfender coderfender force-pushed the deprecate_paste_module branch from d3b8705 to 3fd56d0 Compare March 14, 2026 17:12
@coderfender coderfender marked this pull request as ready for review March 14, 2026 17:12
@coderfender coderfender changed the title chore : deprecate_paste_crate chore: deprecate_paste_crate Mar 14, 2026
@coderfender
Copy link
Contributor Author

@martin-g , ready for your review

@coderfender
Copy link
Contributor Author

coderfender commented Mar 14, 2026

@comphead , I took the more laborious approach to remove paste crate and replace the macro defs with elaborated arguments than trying to find a new crate. Almost all other past crate usage is in tests / non critical path of code with one major usage in UDWF and Error macros

@coderfender coderfender changed the title chore: deprecate_paste_crate chore: Deprecate usage of paste crate Mar 14, 2026
@coderfender coderfender force-pushed the deprecate_paste_module branch from 3fd56d0 to 1e54eeb Compare March 14, 2026 17:50
@coderfender
Copy link
Contributor Author

Fixed a typo simple_udfw instead of simple_udwf

@coderfender
Copy link
Contributor Author

Thank you for the review @martin-g . Fixed the typo with udfw in the docs aignature and fixed macro signature docs per review comments. Take a look whenever you get a chance . Thank you

@coderfender coderfender force-pushed the deprecate_paste_module branch from 6137d6f to 15c04c3 Compare March 16, 2026 03:24
@coderfender coderfender force-pushed the deprecate_paste_module branch from 15c04c3 to 3b893ed Compare March 16, 2026 03:55
@comphead
Copy link
Contributor

we would also need to rollback #20850

@coderfender coderfender force-pushed the deprecate_paste_module branch from 8b77322 to b4812a8 Compare March 16, 2026 18:55
@github-actions github-actions bot added the development-process Related to development process of DataFusion label Mar 16, 2026
@coderfender
Copy link
Contributor Author

@comphead , thank you for the review. I was wondering if we could do it in a different PR but I believe we can do it in the current PR too. I just pushed a commit to unignore the rust warning in git wf. Please take a look whenever you get a chance

@coderfender coderfender force-pushed the deprecate_paste_module branch from 13dad74 to 12dbdeb Compare March 16, 2026 19:02
@alamb alamb changed the title chore: Deprecate usage of paste crate chore: Remove usage of paste crate Mar 16, 2026
@alamb
Copy link
Contributor

alamb commented Mar 16, 2026

this looks great -- thank you @coderfender and @martin-g.

@coderfender
Copy link
Contributor Author

Thank you @alamb

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coderfender this is LGTM
PTAL on comments explaining why underscore variants are needed

@coderfender
Copy link
Contributor Author

Let me address the comments @comphead

@coderfender
Copy link
Contributor Author

@comphead , done . I added the comments in macro def per your review

@comphead
Copy link
Contributor

Thanks @coderfender and @martin-g

@comphead comphead added this pull request to the merge queue Mar 16, 2026
Merged via the queue into apache:main with commit 5d37bab Mar 16, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to common crate core Core DataFusion crate development-process Related to development process of DataFusion functions Changes to functions implementation logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove paste crate from the project

4 participants