chore: Remove usage of paste crate#20946
Conversation
|
TODO : Deprecate paste crate usage in |
d3b8705 to
3fd56d0
Compare
|
@martin-g , ready for your review |
|
@comphead , I took the more laborious approach to remove paste crate and replace the macro defs with elaborated arguments than trying to find a new crate. Almost all other past crate usage is in tests / non critical path of code with one major usage in UDWF and Error macros |
3fd56d0 to
1e54eeb
Compare
|
Fixed a typo |
|
Thank you for the review @martin-g . Fixed the typo with |
6137d6f to
15c04c3
Compare
15c04c3 to
3b893ed
Compare
|
we would also need to rollback #20850 |
8b77322 to
b4812a8
Compare
|
@comphead , thank you for the review. I was wondering if we could do it in a different PR but I believe we can do it in the current PR too. I just pushed a commit to unignore the rust warning in git wf. Please take a look whenever you get a chance |
13dad74 to
12dbdeb
Compare
paste crate
|
this looks great -- thank you @coderfender and @martin-g. |
|
Thank you @alamb |
comphead
left a comment
There was a problem hiding this comment.
Thanks @coderfender this is LGTM
PTAL on comments explaining why underscore variants are needed
|
Let me address the comments @comphead |
|
@comphead , done . I added the comments in macro def per your review |
|
Thanks @coderfender and @martin-g |
Which issue does this PR close?
pastecrate from the project #20853Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?