Skip to content

Fix test that's broken on Windows due to naive path handling #20692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 2 commits into from
Mar 5, 2026
+3 −1
Merged

Fix test that's broken on Windows due to naive path handling #20692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cdbf9b
Fix test that's broken on Windows due to naive path handling
Rafferty97 Mar 4, 2026
bb9384a
Merge branch 'main' into fix-broken-test-windows
Rafferty97 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion datafusion/core/src/datasource/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ mod tests {
use datafusion_physical_plan::collect;
use std::{fs, sync::Arc};
use tempfile::TempDir;
use url::Url;

#[tokio::test]
async fn can_override_physical_expr_adapter() {
Expand Down Expand Up @@ -103,7 +104,8 @@ mod tests {
writer.write(&rec_batch).unwrap();
writer.close().unwrap();

let location = Path::parse(path.to_str().unwrap()).unwrap();
let url = Url::from_file_path(path.canonicalize().unwrap()).unwrap();
let location = Path::from_url_path(url.path()).unwrap();
let metadata = fs::metadata(path.as_path()).expect("Local file metadata");
let meta = ObjectMeta {
location,
Expand Down