fix: fix string to timestamp cast for UTC timestamps#3656
Draft
parthchandra wants to merge 3 commits intoapache:mainfrom
Draft
fix: fix string to timestamp cast for UTC timestamps#3656parthchandra wants to merge 3 commits intoapache:mainfrom
parthchandra wants to merge 3 commits intoapache:mainfrom
Conversation
parthchandra
force-pushed
the
cast-timestamp
branch
from
9365bfc to
2fb1632
Compare
parthchandra
force-pushed
the
cast-timestamp
branch
from
add5ee4 to
0511026
Compare
parthchandra
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #376
Rationale for this change
Part of support for spark 4.0
What changes are included in this PR?
Adds missing Ansi support for cast string to timestamp. Also adds a new error explicitly reporting invalid input for cast to timestamp. (previously we were reporting invalid numeric format).
Also enables the tests for UTC timestamps.
The cast is still marked invalid because some timestamp formats are still not supported. Also, timezone handling is not complete.
How are these changes tested?
Updated unit test