Skip to content

ci: Consolidate Spark SQL test jobs to reduce CI time#3271

Merged
andygrove merged 2 commits intoapache:mainfrom
andygrove:consolidate-spark-sql-tests
Jan 27, 2026
Merged

ci: Consolidate Spark SQL test jobs to reduce CI time#3271
andygrove merged 2 commits intoapache:mainfrom
andygrove:consolidate-spark-sql-tests

Conversation

@andygrove
Copy link
Member

Summary

Merges three near-identical Spark SQL test jobs into a single consolidated job with a config matrix:

  • spark-sql-auto-scan (was 20 jobs)
  • spark-sql-native-native-comet (was 14 jobs)
  • spark-sql-native-iceberg-compat (was 14 jobs, now 7)

Before: 48 jobs across 3 workflows (293 lines)
After: 41 jobs in 1 consolidated workflow (191 lines)
Reduction: ~15% fewer jobs

Test matrix

Scan Implementation Spark Versions Jobs
auto 3.4, 3.5, 4.0 20
native_comet 3.4, 3.5 14
native_iceberg_compat 3.5 7

The native_iceberg_compat scanner is now only tested on Spark 3.5, as testing on 3.4 provides diminishing returns.

Test plan

  • Verify the workflow runs correctly on this PR
  • Check that all expected matrix combinations are generated

🤖 Generated with Claude Code

Merges three near-identical Spark SQL test jobs into a single
consolidated job with a config matrix:

- spark-sql-auto-scan (was 20 jobs)
- spark-sql-native-native-comet (was 14 jobs)
- spark-sql-native-iceberg-compat (was 14 jobs, now 7)

The consolidated job uses a config matrix that defines all
(Spark version, scan implementation) combinations:
- auto scan: Spark 3.4, 3.5, 4.0
- native_comet: Spark 3.4, 3.5
- native_iceberg_compat: Spark 3.5 only

This reduces total jobs from 48 to 41 (~15% reduction) while
maintaining the same test coverage for critical paths.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.13%. Comparing base (f09f8af) to head (c2f3c63).
⚠️ Report is 898 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3271      +/-   ##
============================================
+ Coverage     56.12%   60.13%   +4.00%     
- Complexity      976     1468     +492     
============================================
  Files           119      175      +56     
  Lines         11743    16085    +4342     
  Branches       2251     2665     +414     
============================================
+ Hits           6591     9672    +3081     
- Misses         4012     5066    +1054     
- Partials       1140     1347     +207     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove I def like the clean up, however I'm not sure how 15% fewer jobs are calculated, this PR has 118 checks completed vs #3266 (122 checks)

@andygrove
Copy link
Member Author

Thanks @andygrove I def like the clean up, however I'm not sure how 15% fewer jobs are calculated, this PR has 118 checks completed vs #3266 (122 checks)

15% fewer Spark SQL jobs, not 15% fewer total jobs, I think

@andygrove andygrove merged commit 72496da into apache:main Jan 27, 2026
123 checks passed
@andygrove andygrove deleted the consolidate-spark-sql-tests branch January 27, 2026 00:04
vigneshsiva11 pushed a commit to vigneshsiva11/datafusion-comet that referenced this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants