bug: Fix string decimal type throw right exception

[coderfender]

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.13%. Comparing base (f09f8af) to head (918797a).
⚠️ Report is 907 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3248      +/-   ##
============================================
+ Coverage     56.12%   60.13%   +4.00%     
- Complexity      976     1468     +492     
============================================
  Files           119      175      +56     
  Lines         11743    16085    +4342     
  Branches       2251     2665     +414     
============================================
+ Hits           6591     9672    +3081     
- Misses         4012     5066    +1054     
- Partials       1140     1347     +207     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderfender]

Root cause for test failures :

1. New inputs are generated exposing new edge cases / bugs
2. New exception messages ( CastInvalidValue vs NumericValueOutOfRange which was previously not present)

[andygrove]

do we need to allocate this string here with the format!? It looks like this string is only used when an error occurs?

Can you share benchmarks showing before/after these changes?

[coderfender]

Sure @andygrove

[coderfender]

We don't currently hve string to decimal cast benchmarks at the moment. Let me create the benchmarks (based on string to int casting inputs) and rerun the benchmarks before and after string allocation fix

[coderfender]

Thank you . I was able to fix the unwanted allocation and improved performance by 2x

[coderfender]

Thank you for the suggestion @andygrove . These are the benchmarks before and after removing string allocations even for happy paths

group                                          before                                 new
-----                                          ------                                 ---
cast_string_to_decimal/ansi/decimal_38_10      2.07     80.0±3.79µs        ? ?/sec    1.00     38.6±0.48µs        ? ?/sec
cast_string_to_decimal/legacy/decimal_38_10    2.04     78.4±1.30µs        ? ?/sec    1.00     38.4±2.11µs        ? ?/sec
cast_string_to_decimal/try/decimal_38_10       1.98     79.6±2.35µs        ? ?/sec    1.00     40.2±3.15µs        ? ?/sec
  

[andygrove]

LGTM, pending CI. Thanks @coderfender!

[coderfender]

Thank you for the approval @andygrove. Please merge whenever you get a chance