feat: [EXPERIMENTAL] Add cost-based optimizer (CBO) for Comet vs Spark execution#3220
Closed
andygrove wants to merge 2 commits intoapache:mainfrom
Closed
feat: [EXPERIMENTAL] Add cost-based optimizer (CBO) for Comet vs Spark execution#3220andygrove wants to merge 2 commits intoapache:mainfrom
andygrove wants to merge 2 commits intoapache:mainfrom
Conversation
…execution This PR introduces an experimental lightweight cost-based optimizer that estimates whether a Comet query plan will be faster than a Spark plan, falling back to Spark when Comet execution is estimated to be slower. **Key Features:** - Heuristic-based cost model with configurable weights for different operator types (scan, filter, project, aggregate, join, sort) - Configurable speedup factors for each Comet operator type - Transition penalty for columnar<->row conversions - Cardinality estimation using Spark's logical plan statistics - CBO analysis included in EXPLAIN output when enabled **Configuration:** - `spark.comet.cbo.enabled` (default: false) - Enable/disable CBO - `spark.comet.cbo.speedupThreshold` (default: 1.0) - Minimum speedup required - `spark.comet.cbo.explain.enabled` (default: false) - Log CBO decisions **Important Notes:** - This is an EXPERIMENTAL feature, disabled by default - CBO only affects operator conversion (filter, project, aggregate, etc.), not scan conversion which is handled by CometScanRule - Default parameters are initial estimates and should be tuned with benchmarks Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Enhance the CBO cost model to consider the cost of individual expressions
in projections and filters, rather than using a fixed cost per operator.
Key changes:
- Add DEFAULT_EXPR_COSTS map with cost multipliers for common expressions
(e.g., AttributeReference=0.1 since Comet just clones arrays)
- Add dynamic config override via spark.comet.cbo.exprCost.<ExpressionName>
- Update cost calculation to sum expression costs in filters/projects
- Add CometCBOSuite to CI workflows (Linux and macOS)
- Add 6 new tests for expression-based costing
Expression cost multipliers:
- < 1.0 means Comet is faster for this expression
- > 1.0 means Spark is faster for this expression
- 1.0 means they are equivalent
Example config override:
spark.conf.set("spark.comet.cbo.exprCost.MyCustomExpr", "1.5")
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an experimental lightweight cost-based optimizer (CBO) that estimates whether a Comet query plan will be faster than a Spark plan, falling back to Spark when Comet execution is estimated to be slower.
Key Features
Configuration Options
spark.comet.cbo.enabledfalsespark.comet.cbo.speedupThreshold1.0spark.comet.cbo.explain.enabledfalseAdditional internal configs for tuning weights and speedup factors are available (see
CometConf.scala).How It Works
CometExecRuletransforms operators to Comet equivalents, CBO analyzes the planLimitations
CometScanRuleExample Usage
Files Changed
CometCostEstimator.scala- Core cost estimation logicCometCBOSuite.scala- Unit testsCometConf.scala- Configuration optionsCometExecRule.scala- CBO integrationExtendedExplainInfo.scala- CBO info in EXPLAINTest plan
CometCBOSuite(13 tests)CometExecRuleSuitetests pass🤖 Generated with Claude Code