feat: Support map sort expression#3210
Draft
Shekharrajak wants to merge 7 commits intoapache:mainfrom
Draft
Conversation
MapSort only exists in Spark 4.0+, not in 3.4/3.5
Adds MapSort serialization to Spark 4.0 version shim
Resolved conflicts: - native/spark-expr/src/comet_scalar_funcs.rs: Combined spark_map_sort and SparkDateDiff imports - spark-4.0/.../CometExprShim.scala: Combined MapSort and WidthBucket case statements
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3210 +/- ##
============================================
- Coverage 56.12% 54.90% -1.23%
- Complexity 976 1432 +456
============================================
Files 119 175 +56
Lines 11743 16165 +4422
Branches 2251 2681 +430
============================================
+ Hits 6591 8875 +2284
- Misses 4012 6017 +2005
- Partials 1140 1273 +133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Tests are failing: @Shekharrajak I'll move this to draft for now. Please mark as ready to review once the test failures ares resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3171
Rationale for this change
Implement native execution support for Apache Spark's map_sort expression, enabling efficient sorting of map entries by keys in ascending order within Comet's native execution engine.
What changes are included in this PR?
How are these changes tested?