[JCS-244] Fix the LateralTCPListener.handleClient to survive other exceptions#407
[JCS-244] Fix the LateralTCPListener.handleClient to survive other exceptions#407orlat84 wants to merge 5 commits intoapache:release-3.2.1from
Conversation
…java.nio.BufferUnderflowException or other exceptions
Updated the version as per the warning message
Updated cache version to v3 as per the warning message
garydgregory
left a comment
There was a problem hiding this comment.
You'll want to add a unit test to this PR, otherwise this will be a regression waiting to happen.
| with: | ||
| persist-credentials: false | ||
| - uses: actions/cache@v3.3.1 | ||
| - uses: actions/cache@v3 |
There was a problem hiding this comment.
Modified it, as some pipelines were failing and was getting notifications quite often on this
| persist-credentials: false | ||
| - uses: actions/cache@v3.3.1 | ||
| with: | ||
| persist-credentials: false |
There was a problem hiding this comment.
Modified it, as some pipelines were failing and was getting notifications quite often on this
|
CC @tvand |
|
Hi Florin, Please note that I will not fix this issue in the jcs3 release anymore but in jcs4 (master branch). |
|
Fixed with commit 96db75a |
In case a java.nio.BufferUnderflowException occurs in LateralTCPListener.handleClient the listener thread dies and does not recover, then the cache cluster is no longer consistent.
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.