Remove realhostip references from the code#12856
Remove realhostip references from the code#12856vishesh92 wants to merge 2 commits intoapache:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12856 +/- ##
============================================
+ Coverage 17.95% 18.02% +0.07%
- Complexity 16259 16450 +191
============================================
Files 5954 5968 +14
Lines 534838 537079 +2241
Branches 65423 65959 +536
============================================
+ Hits 96010 96819 +809
- Misses 428053 429340 +1287
- Partials 10775 10920 +145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR aims to remove legacy realhostip domain references across CloudStack (tests, SystemVM packaging/scripts, and management-server logic), and to clear stale configuration values during upgrade.
Changes:
- Replace
*.realhostip.com/realhostip.comreferences in tests and comments with*.example.com/example.com. - Rename/update SystemVM truststore/cert/key filenames from
realhostip.*tosystemvm.*and update related scripts/poms to reference the new names. - Remove legacy “only realhostip supported” warnings and add an upgrade SQL to null out stale
realhostipconfiguration values.
Reviewed changes
Copilot reviewed 13 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/src/test/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtilTest.java | Updates test domain strings away from realhostip. |
| systemvm/pom.xml | Updates quickcloud trustStore filename to systemvm.keystore. |
| systemvm/patch-sysvms.sh | Updates keystore path used when importing JVM cacerts. |
| systemvm/debian/opt/cloud/bin/setup/bootstrap.sh | Updates keystore path used during systemvm bootstrap. |
| systemvm/agent/scripts/config_ssl.sh | Renames default cert/key/keystore filenames used for SSL setup. |
| systemvm/agent/scripts/_run.sh | Updates agent JVM trustStore filename to systemvm.keystore. |
| systemvm/agent/certs/systemvm.keystore | Adds/renames keystore artifact used by SystemVM components. |
| systemvm/agent/certs/systemvm.key | Adds/renames private key artifact used by SystemVM SSL setup. |
| systemvm/agent/certs/systemvm.csr | Adds/renames CSR artifact. |
| systemvm/agent/certs/systemvm.crt | Adds/renames certificate artifact. |
| services/secondary-storage/server/pom.xml | Updates trustStore filename to systemvm.keystore. |
| services/console-proxy/server/pom.xml | Updates excluded CSR filename to systemvm.csr. |
| server/src/test/java/com/cloud/keystore/KeystoreTest.java | Updates hard-coded test domain strings away from realhostip. |
| server/src/main/java/com/cloud/storage/upload/UploadMonitorImpl.java | Removes legacy realhostip fallback/logic and adjusts URL generation behavior. |
| server/src/main/java/com/cloud/storage/download/DownloadMonitorImpl.java | Removes legacy warning tied to realhostip domain/cert expectations. |
| server/src/main/java/com/cloud/server/ConfigurationServerImpl.java | Clears the legacy secstorage.secure.copy.cert default value. |
| engine/schema/src/main/resources/META-INF/db/schema-42210to42300.sql | Clears stale realhostip configuration values during upgrade. |
| .pre-commit-config.yaml | Updates pre-commit allowlist to match the renamed private key filename. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| hostname = hostname + "." + _ssvmUrlDomain; | ||
| } else { | ||
| hostname = hostname + ".realhostip.com"; | ||
| logger.warn("SSL copy is enabled but secstorage.ssl.cert.domain is not configured; " | ||
| + "using IP address directly. Configure a wildcard SSL certificate domain for proper HTTPS support."); | ||
| hostname = ipAddress; |
|
@blueorangutan package |
|
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17193 |
|
@blueorangutan test keepEnv |
|
@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
overall lgtm my only concern is, will live-patch of system vms (created before upgrade) work ? |
Yes. I have made the changes but didn't test them. |
|
[SF] Trillian test result (tid-15691)
|
|
@blueorangutan package I have done some testing. The fresh build is working fine. For upgrades (followed docs) & systemVM patching I followed these steps:
|
|
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled withI have done some testing. The fresh build is working fine. For upgrades (followed docs) & systemVM patching I followed these steps:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17230 |
|
@blueorangutan test matrix |
|
@vishesh92 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-15720) |
|
[SF] Trillian Build Failed (tid-15723) |
|
[SF] Trillian test result (tid-15719)
|
|
[SF] Trillian test result (tid-15721)
|
Description
This PR removes references for realhostip.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?