Skip to content

Comments

ui: refactor advisories enabled usage and more#12676

Open
shwstppr wants to merge 3 commits intoapache:mainfrom
shwstppr:ui-adv-improv
Open

ui: refactor advisories enabled usage and more#12676
shwstppr wants to merge 3 commits intoapache:mainfrom
shwstppr:ui-adv-improv

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Feb 21, 2026

Description

Considers advisoriesDisabled as false if no value is found in the config or if set to false.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Considers advisoriesDisabled as false if no value is found in the config
or if set to false.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.92%. Comparing base (30e6c22) to head (19e8477).

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #12676   +/-   ##
=========================================
  Coverage     17.92%   17.92%           
- Complexity    16154    16158    +4     
=========================================
  Files          5939     5940    +1     
  Lines        533181   533240   +59     
  Branches      65237    65237           
=========================================
+ Hits          95585    95597   +12     
- Misses       426856   426904   +48     
+ Partials      10740    10739    -1     
Flag Coverage Δ
uitests 3.66% <ø> (-0.01%) ⬇️
unittests 19.04% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@sudo87 sudo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr changed the title ui: refactor advisories enabled usage ui: refactor advisories enabled usage and more Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants