Add bypassvlanoverlapcheck parameter to cloudstack_private_gateway #283
Open
bhouse-nexthop wants to merge 2 commits intoapache:mainfrom
Open
Add bypassvlanoverlapcheck parameter to cloudstack_private_gateway #283bhouse-nexthop wants to merge 2 commits intoapache:mainfrom
bhouse-nexthop wants to merge 2 commits intoapache:mainfrom
Conversation
Collaborator
bhouse-nexthop
commented
Mar 6, 2026
bhouse-nexthop
commented
- Add bypassvlanoverlapcheck optional parameter (defaults to false)
- Parameter allows bypassing VLAN overlap checks during gateway creation
- Update resource creation logic to pass parameter to CloudStack API
- Add comprehensive test coverage:
- Test with bypass enabled
- Test default value (false)
- Update import test to ignore field (not returned by API)
- Update documentation with examples and parameter description
- All acceptance tests passing (4/4)
…source - Add bypassvlanoverlapcheck optional parameter (defaults to false) - Parameter allows bypassing VLAN overlap checks during gateway creation - Update resource creation logic to pass parameter to CloudStack API - Add comprehensive test coverage: - Test with bypass enabled - Test default value (false) - Update import test to ignore field (not returned by API) - Update documentation with examples and parameter description - All acceptance tests passing (4/4)
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for an optional bypassvlanoverlapcheck flag on cloudstack_private_gateway, enabling callers to bypass CloudStack’s VLAN overlap validation at creation time.
Changes:
- Documented the new
bypassvlanoverlapcheckargument and added an HCL example. - Extended the private gateway resource schema and create logic to pass the flag to the CloudStack API.
- Added/updated acceptance tests to cover explicit
true, defaultfalse, and import behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
cloudstack/resource_cloudstack_private_gateway.go |
Adds schema field and wires it into the Create API call. |
cloudstack/resource_cloudstack_private_gateway_test.go |
Adds acceptance tests and updates import verification to ignore the new field. |
website/docs/r/private_gateway.html.markdown |
Documents the new argument and provides an example configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… consistency The parameter name has been changed from camelCase (bypassvlanoverlapcheck) to snake_case (bypass_vlan_overlap_check) to maintain consistency with other resource arguments like ip_address, physical_network_id, and acl_id. This change affects: - Resource schema definition - Resource creation logic - Test cases and assertions - Documentation examples The parameter is now also marked as ForceNew since it can only be set during gateway creation and cannot be modified afterwards.
Collaborator
Author
|
@vishesh92 code review comments addressed, please re-request from copilot |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.