Remove redundent Shared Scan after dedup subquery#1460
Closed
weinan003 wants to merge 1 commit intoapache:mainfrom
Closed
Remove redundent Shared Scan after dedup subquery#1460weinan003 wants to merge 1 commit intoapache:mainfrom
weinan003 wants to merge 1 commit intoapache:mainfrom
Conversation
After subquery dedup(ref. a031a4a), The cte consumer need to decrement, so that XformInlineCTE can help us rid of unnecessary Shared Scan node. TODO: 1. Instead of mock CTE MDID, we should parser CTE related relation MDID, and dedup CTE with other flat subquery together. 2. inner join subquery, join order should not involve into dedup comparation 3. For subquery, not only AndOp but also OrOp can dedup
yjhjstz
reviewed
Dec 1, 2025
| void | ||
| Decrement() | ||
| { | ||
| GPOS_ASSERT(m_ulCount > 1); |
Member
There was a problem hiding this comment.
why GPOS_ASSERT(m_ulCount > 1);?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After subquery dedup(ref. a031a4a), The cte consumer need to decrement, so that XformInlineCTE can help us rid of unnecessary Shared Scan node.
TODO:
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions