CAMEL-20199: Replace synchronized with ReentrantLock for virtual thread compatibility#21703
Open
CAMEL-20199: Replace synchronized with ReentrantLock for virtual thread compatibility#21703
Conversation
…al thread compatibility Virtual threads (JDK 21+) can be pinned to carrier threads when they enter synchronized blocks, degrading throughput. This replaces synchronized blocks/methods with ReentrantLock or better concurrent data structures across core and components: Core: - Suppliers.java: synchronized → ReentrantLock for memoization - DefaultModel.java: 9 synchronized methods → ReentrantLock - DefaultCamelContext.java: synchronized(model) → model lock Components: - Sqs2Endpoint: volatile + ReentrantLock double-checked locking, removed redundant queueUrlInitialized flag - MockEndpoint: synchronized → ReentrantLock - GoogleFirestoreConsumer: synchronized + LinkedList → ConcurrentLinkedQueue - GooglePubsubConsumer: synchronizedList → CopyOnWriteArrayList - SubscriptionManager: 12 synchronized constructs → ReentrantLock - MiloClientConnection: synchronized → ReentrantLock - CamelNamespace: synchronized → ReentrantLock Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
…entConsumers description Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
davsclaus
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
synchronizedblocks/methods withReentrantLockor better concurrent data structures across core modules and components to prevent virtual thread pinning (JDK 21+)synchronizedblocks, degrading throughput.ReentrantLockdoes not cause pinning.ConcurrentLinkedQueue,CopyOnWriteArrayList,volatilewith double-checked lockingCore changes
Suppliers.javasynchronized→ReentrantLockfor memoizationDefaultModel.javasynchronizedmethods → singleReentrantLock(reentrant for nested calls)DefaultCamelContext.javasynchronized(model)→ usesDefaultModel's lockComponent changes
camel-aws2-sqsvolatile+ReentrantLockdouble-checked locking, removed redundantqueueUrlInitializedflagcamel-mocksynchronized→ReentrantLockcamel-google-firestoresynchronized+LinkedList→ConcurrentLinkedQueue(lock-free)camel-google-pubsubsynchronizedList→CopyOnWriteArrayList(lock-free)camel-milosynchronizedconstructs →ReentrantLockacrossSubscriptionManager,MiloClientConnection,CamelNamespaceIntentionally skipped
CxfConsumer: synchronizes on per-requestcontinuationobject — brief pinning, CXF API constraintKameletComponent,CamelWebSocketHandler: already useReentrantLockTest plan
🤖 Generated with Claude Code