Fix postcommit python validates container dataflow

[aIbrahiim]

Fixes: #33064
Fixes: #36721
Successful run: https://github.com/apache/beam/actions/runs/21631628144

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @aIbrahiim, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issues in the Python SDK's container dataflow validation during post-commit checks. It refines how Cloud Build requests are constructed by correcting attribute assignments for source storage and streamlines the process of extracting build-related information from Cloud Build metadata. These changes ensure more robust and accurate interaction with the Cloud Build API for container image management.

Highlights

• Cloud Build Source Object Correction: Corrected the assignment of the storageSource attribute and its object_ field within the _invoke_docker_build_and_push method to properly interact with the Cloud Build API types.
• Simplified Build Metadata Extraction: Refactored the _get_cloud_build_id_and_log_url method to directly access build.id and build.log_url from the metadata object, simplifying the code and improving readability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sdks/python/apache_beam/runners/portability/sdk_container_builder.py
  • Updated the _invoke_docker_build_and_push method to correctly assign the storage_source object and its object_ attribute, resolving a potential API incompatibility or naming conflict.
  • Modified the _get_cloud_build_id_and_log_url method to directly retrieve build.id and build.log_url from the metadata.build object, removing the need for manual iteration through additionalProperties.

Activity

• The author, aIbrahiim, has provided a successful run link for the changes: https://github.com/apache/beam/actions/runs/21631628144, indicating that the changes have passed initial testing.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Assigning reviewers:

R: @damccorm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[damccorm]

Thanks!

[damccorm]

Waiting on precommit checks to finish before merging

[aIbrahiim]

Waiting on precommit checks to finish before merging

I think precommit failed because of CI timing @damccorm

[Amar3tto]

Checks passed