-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48924: [C++][CI] Fix pre-buffering issues in IPC file reader #48925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
c559b54 to
7749642
Compare
|
@github-actions crossbow submit -g cpp |
|
Revision: 7749642 Submitted crossbow builds: ursacomputing/crossbow @ actions-cab35a473b |
7749642 to
a4ae909
Compare
|
I'm not overly familiar with this part of Arrow, but generally things look good to me. Happy to offer an explicit approval if desired and no feedback from others |
|
After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 8010794. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 16 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 8010794. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 16 possible false positives for unstable benchmarks that are known to sometimes produce them. |
What changes are included in this PR?
Bug fixes and robustness improvements in the IPC file reader:
Testing improvements:
Miscellaneous:
Are these changes tested?
Yes, by existing and improved tests.
Are there any user-facing changes?
Bug fixes.
This PR contains a "Critical Fix". Fixes a potential crash reading variadic buffers with pre-buffering enabled.