GH-48723: [C++] Test filter operations with random null probabilities#48724
Open
HyukjinKwon wants to merge 1 commit intoapache:mainfrom
Open
GH-48723: [C++] Test filter operations with random null probabilities#48724HyukjinKwon wants to merge 1 commit intoapache:mainfrom
HyukjinKwon wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
HyukjinKwon
force-pushed
the
GH-48723
branch
8 times, most recently
from
4921218 to
e598211
Compare
EnricoMi
reviewed
Jan 6, 2026
github-actions
bot
added
awaiting committer review
EnricoMi
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
d0f3b5f introduced the todo:
arrow/cpp/src/arrow/compute/kernels/vector_selection_test.cc
Line 518 in 727106f
which I presumed that the author forgot to address this.
What changes were included in this PR?
CompareAndFilterhelper functions null-aware by checking validity bitmapAre these changes tested?
Yes, new tests were added to address nulls, and locally tested.
Are there any user-facing changes?
No, test-only.