Skip to content

MINOR: [C++][FlightRPC] Clarify IsAutoUnique equivalence between ODBC 2.0 and 3.0+ #48689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 1 commit into from
Jan 3, 2026
+3 −1
Merged

MINOR: [C++][FlightRPC] Clarify IsAutoUnique equivalence between ODBC 2.0 and 3.0+ #48689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_result_set_metadata.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,9 @@ Updatability FlightSqlResultSetMetadata::GetUpdatable(int column_position) {
bool FlightSqlResultSetMetadata::IsAutoUnique(int column_position) {
ColumnMetadata metadata = GetMetadata(schema_->field(column_position - 1));

// TODO: Is AutoUnique equivalent to AutoIncrement?
// AUTO_UNIQUE_VALUE (ODBC 3.0+) is equivalent to
// AUTO_INCREMENT (ODBC 2.0). Both indicate columns
// that automatically generate unique values.
Comment on lines +225 to +227
Copy link
Contributor

@alinaliBQ alinaliBQ Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the statement is correct.

return metadata.GetIsAutoIncrement().ValueOrElse([] { return false; });
}

Expand Down
Loading