GH-48682: [C++] Remove IPC dependency from array_union_test.cc by moving MakeUnion to testing utilities #48683
+65
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HyukjinKwon
force-pushed
the
refactor-test-ipc
branch
2 times, most recently
from
d2dc181 to
7f86def
Compare
…ion to testing utilities
HyukjinKwon
force-pushed
the
refactor-test-ipc
branch
from
7f86def to
0d96855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
arrow/cpp/src/arrow/array/array_union_test.cc
Line 25 in 0c694e7
Avoid dependencies of IPC in Array tests.
What changes are included in this PR?
This PR proposes to move
MakeUniontoarrow/testing/util.ccand avoid the dependency.Are these changes tested?
Existing tests should cover this.
Are there any user-facing changes?
No, test-only.