[Json] Add benchmarks for list json reader#9507
Open
liamzwbao wants to merge 2 commits intoapache:mainfrom
Open
[Json] Add benchmarks for list json reader#9507liamzwbao wants to merge 2 commits intoapache:mainfrom
liamzwbao wants to merge 2 commits intoapache:mainfrom
Conversation
liamzwbao
force-pushed
the
issue-9497-list-json-reader-bench
branch
from
7219290 to
cfaea69
Compare
Rafferty97
approved these changes
Mar 9, 2026
| group.throughput(Throughput::Elements(ROWS as u64)); | ||
| group.bench_function("short", |b| { | ||
| b.iter(|| { | ||
| let mut buf = Vec::with_capacity(ROWS * LIST_SHORT_ELEMENTS * 8); |
Contributor
There was a problem hiding this comment.
Is it worth extracting this Vec allocation out of the benchmark code, and instead reusing the same buffer with .clear(), to keep the benchmark focused on the speed of the actual writing?
| // Long lists: tests child element encode throughput (many elements per row) | ||
| group.bench_function("long", |b| { | ||
| b.iter(|| { | ||
| let mut buf = Vec::with_capacity(ROWS * LIST_LONG_ELEMENTS * 8); |
Contributor
There was a problem hiding this comment.
Same as above: extract allocation?
|
|
||
| group.bench_function("short", |b| { | ||
| b.iter(|| { | ||
| let mut buf = Vec::with_capacity(ROWS * LIST_SHORT_ELEMENTS * 8); |
Contributor
There was a problem hiding this comment.
Same as above: extract allocation?
|
|
||
| group.bench_function("long", |b| { | ||
| b.iter(|| { | ||
| let mut buf = Vec::with_capacity(ROWS * LIST_LONG_ELEMENTS * 8); |
Contributor
There was a problem hiding this comment.
Same as above: extract allocation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ArrayDataBuilderwithGenericListArrayinListArrayDecoder#9497.Rationale for this change
Add benchmark for
ListArrayinjson_readerto support the performance evaluation of #9497What changes are included in this PR?
ListArray.ListArrayandFixedSizeListArrayjson writerAre these changes tested?
Benchmarks only
Are there any user-facing changes?
No