Skip to content

Add Helm Refurbish approach into dev docs#64063

Merged
bugraoz93 merged 2 commits intoapache:mainfrom
bugraoz93:add-helm-refurbish-approach
Mar 24, 2026
Merged

Add Helm Refurbish approach into dev docs#64063
bugraoz93 merged 2 commits intoapache:mainfrom
bugraoz93:add-helm-refurbish-approach

Conversation

@bugraoz93
Copy link
Contributor

@bugraoz93 bugraoz93 commented Mar 22, 2026

related: #64037
Add README_HELM_CHART2_DEV.md and update README_AIRFLOW3_DEV.md


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Some code completions over titles and list items.
Used Claude 4.


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@jscheffl
Copy link
Contributor

FYI @Miretpl @wolfdn

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will let others review as well @jedcunningham @Miretpl

Copy link
Contributor

@Miretpl Miretpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the non-trivial refactoring which is mentioned in a couple of places, can be confusing for users in terms of what is trivial refactoring and what is not. On the other hand, we want to have some grey area here, but the question is - could/should we make it a little more precise?

In general - LGTM

@bugraoz93 bugraoz93 force-pushed the add-helm-refurbish-approach branch from 8512a4d to ec3ff44 Compare March 23, 2026 18:22
@bugraoz93
Copy link
Contributor Author

I think that the non-trivial refactoring which is mentioned in a couple of places, can be confusing for users in terms of what is trivial refactoring and what is not. On the other hand, we want to have some grey area here, but the question is - could/should we make it a little more precise?

In general - LGTM

Thanks @Miretpl for your comment! I deleted non-trivial description from any kind of refactor keywords. Those shouldn't be needed in backcompat rather fixes or things should small enough to follow up.

...
## Merging PRs targeted for Airflow Helm Chart 2.X

PRs should target `main` branch.
We will cherry-pick relevant changes to `chart/v1-2x-test` branch if we decide that they are relevant to the latest release.
...

I have added this to be more precise rather the gray area is now confluence document that is already on going (connected Google Doc and Github Issue in the Confluence page) if anyone really want to dig deep and can leave comment to any of those items (Google Docs, Github issue) :) If you still this won't be enough, I can add a section to maybe explain the things can change by the time to explain the gray area better. What do you think?

Copy link
Contributor

@Miretpl Miretpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bugraoz93 looks good, thanks!

@bugraoz93 bugraoz93 force-pushed the add-helm-refurbish-approach branch from ec3ff44 to 5bc6dbf Compare March 24, 2026 16:53
@bugraoz93 bugraoz93 merged commit fd64824 into apache:main Mar 24, 2026
37 checks passed
@bugraoz93 bugraoz93 deleted the add-helm-refurbish-approach branch March 24, 2026 16:54
github-actions bot pushed a commit that referenced this pull request Mar 24, 2026
* Add README_HELM_CHART2_DEV.md and update README_AIRFLOW3_DEV.md
(cherry picked from commit fd64824)

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
@github-actions
Copy link

Backport successfully created: v3-1-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-1-test PR Link

vatsrahul1001 pushed a commit that referenced this pull request Mar 25, 2026
* Add README_HELM_CHART2_DEV.md and update README_AIRFLOW3_DEV.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants