Add Helm Refurbish approach into dev docs#64063
Conversation
potiuk
left a comment
There was a problem hiding this comment.
LGTM. I will let others review as well @jedcunningham @Miretpl
Miretpl
left a comment
There was a problem hiding this comment.
I think that the non-trivial refactoring which is mentioned in a couple of places, can be confusing for users in terms of what is trivial refactoring and what is not. On the other hand, we want to have some grey area here, but the question is - could/should we make it a little more precise?
In general - LGTM
8512a4d to
ec3ff44
Compare
Thanks @Miretpl for your comment! I deleted non-trivial description from any kind of refactor keywords. Those shouldn't be needed in backcompat rather fixes or things should small enough to follow up. ...
## Merging PRs targeted for Airflow Helm Chart 2.X
PRs should target `main` branch.
We will cherry-pick relevant changes to `chart/v1-2x-test` branch if we decide that they are relevant to the latest release.
...I have added this to be more precise rather the gray area is now confluence document that is already on going (connected Google Doc and Github Issue in the Confluence page) if anyone really want to dig deep and can leave comment to any of those items (Google Docs, Github issue) :) If you still this won't be enough, I can add a section to maybe explain the things can change by the time to explain the gray area better. What do you think? |
Miretpl
left a comment
There was a problem hiding this comment.
@bugraoz93 looks good, thanks!
ec3ff44 to
5bc6dbf
Compare
* Add README_HELM_CHART2_DEV.md and update README_AIRFLOW3_DEV.md (cherry picked from commit fd64824) Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
Backport successfully created: v3-1-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
* Add README_HELM_CHART2_DEV.md and update README_AIRFLOW3_DEV.md
related: #64037
Add README_HELM_CHART2_DEV.md and update README_AIRFLOW3_DEV.md
Was generative AI tooling used to co-author this PR?
Some code completions over titles and list items.
Used Claude 4.
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.