Skip to content

Add dedupe logic for Deadline Alerts (#63856) #64036

Open
Lavanya14-Y wants to merge 1 commit intoapache:mainfrom
Lavanya14-Y:dedupe-deadline-alerts
Open

Add dedupe logic for Deadline Alerts (#63856) #64036
Lavanya14-Y wants to merge 1 commit intoapache:mainfrom
Lavanya14-Y:dedupe-deadline-alerts

Conversation

@Lavanya14-Y
Copy link

Fixes #63856

  • Adds logic to prevent duplicate Deadline Alert emails
  • Example output:

Sending email for dag_1 to abc@example.com
Skipping email for dag_1
Sending email for dag_2 to xyz@example.com

Implement deduplication for email alerts based on DAG ID.

<! -- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Implement deduplication for email alerts based on DAG ID.
@Lavanya14-Y
Copy link
Author

Fixes #63856
Please review this PR. I have added deduplication logic for Deadline Alerts.

@Srabasti
Copy link
Contributor

Looks like Apache License is missing in file header @Lavanya14-Y, as a result static checks are failing.
Try running prek in your local branch and then commit to Airflow github repo.
Remember to rebase to ensure latest fixes are in!

@Srabasti
Copy link
Contributor

The tests should be in a different file I believe, as unit tests, and not in the source code, like other functionality. Thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Deadline Alerts] Dedupe Callbacks

2 participants