improve grid/ti_summaries and grid/runs#64034
Open
henry3260 wants to merge 1 commit intoapache:mainfrom
Open
Conversation
5d0add7 to
4691a38
Compare
4691a38 to
de430af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The previous implementation scaled poorly for DAGs that combine:
TaskGroupnestingIn particular,
grid/ti_summarieswas keepingdetailsduring aggregation even though those details are not part of the response model. This meant we were paying extra CPU and memory cost for intermediate data that was never returned to the client.I don't think we should keep
detailsin the summary path, because the response does not include them. Keeping them only increases temporary allocations and repeated copying when task-group summaries are rolled up.What
This improves the Grid API performance for DAGs with large mapped task instance cardinality.
There are two main changes:
grid/runsno longer loads alltask_instances/task_instances_historiesfor everyDagRunon the page just to computedag_versions.Instead, it fetches the paginated runs first and then performs a slimmer lookup for the distinct DAG versions needed for the response.
grid/ti_summariesno longer builds and propagates full per-task-instancedetailslists while aggregating task groups.It now keeps only the summary data needed for the response, such as child state counts and min/max dates.
Why
The previous implementation scaled poorly for DAGs that combine:
TaskGroupnestingIn particular,
grid/ti_summarieswas keepingdetailsduring aggregation even though those details are not part of the response model. This meant we were paying extra CPU and memory cost for intermediate data that was never returned to the client.I don't think we should keep
detailsin the summary path, because the response does not include them. Keeping them only increases temporary allocations and repeated copying when task-group summaries are rolled up.Result
This keeps the API contract unchanged, but reduces unnecessary ORM loading and Python-side aggregation work.
On a local benchmark with 5 DAG runs and about 4002 task instances per run:
grid/runsmedian latency improved from ~2955 ms to ~43 msgrid/runstracemalloc peak dropped from ~104.6 MiB to ~1.7 MiBgrid/ti_summariestracemalloc peak dropped from ~5.4 MiB to ~1.7 MiBrelated: #63975
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.