AMQP: added transport factory unit tests for mutex stripping and monitor wiring.#1725
Open
asaxena14 wants to merge 5 commits intoapache:mainfrom
Open
AMQP: added transport factory unit tests for mutex stripping and monitor wiring.#1725asaxena14 wants to merge 5 commits intoapache:mainfrom
asaxena14 wants to merge 5 commits intoapache:mainfrom
Conversation
jbonofre
reviewed
Feb 25, 2026
.../src/test/java/org/apache/activemq/transport/amqp/AmqpTransportFactoryConfigurationTest.java
Outdated
Show resolved
Hide resolved
Author
|
CI Quick is blocked as workflow is awaiting approval from a maintainer. Can someone Please provide an approval for this. Thanks |
jbonofre
approved these changes
Mar 13, 2026
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
nit: the tests look good but they are mostly testing the happy path. It would be great to add some tests for "corner" cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds focused unit coverage for AMQP transport factories to validate configuration behaviour.
Added test:
AmqpTransportFactoryConfigurationTest.java
Factories covered:
What is verified: