Open
Conversation
Owner
|
Thank you for the patch! Now I have some reading up to do. 🙂
You could have filed a feature request! 🙂 I haven’t been keeping up with developments in the web standards anything like as close as I used to so I didn’t notice CSS Color falling out of date – but it is meant to support the full spec, and nudges in that direction are always welcome and appreciated. |
Author
I could also just do it. 😀 (Seriously, filing a good feature request would have taken almost as much effort as just implementing it. This is why I love open source software as distinct from just free software.) |
Things now supported: • Fractions: hsl(25.7, 100%, 53.3%) = #f71. • Hue units deg, rad, grad, turn. • Negative hue rotations. • The fairly new commaless syntax: rgb(0 255 0) = rgb(0, 255, 0), hsl(210 50% 50% / 50%) = hsla(210, 50%, 50%, 0.5). I’ve added just one simple demonstration test. I’m too lazy to add it to more sample files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things now supported:
hsl(25.7, 100%, 53.3%)=#f71.deg,rad,grad,turn.rgb(0 255 0)=rgb(0, 255, 0),hsl(210 50% 50% / 50%)=hsla(210, 50%, 50%, 0.5).I’ve added just one simple demonstration test. I’m too lazy to add it to more sample files.
(I finally got sufficiently fed up with these things not working to spend a few minutes fixing it. 🙂)