fix: normalize windows path separators in session queries#19645
Closed
tcflying wants to merge 2 commits intoanomalyco:devfrom
Closed
fix: normalize windows path separators in session queries#19645tcflying wants to merge 2 commits intoanomalyco:devfrom
tcflying wants to merge 2 commits intoanomalyco:devfrom
Conversation
Fixes Windows session list display issues where sessions become invisible due to path separator inconsistencies. Changes: - Add normalizePathSeparators() function to filesystem utilities - Normalize paths in session.createNext() when storing sessions - Normalize paths in Session.list() when querying by directory - Normalize paths in Session.listGlobal() when querying by directory - Normalize paths in Project.discover() when updating session project IDs This resolves GitHub Issues anomalyco#16744 and anomalyco#18029 where sessions created with backslash paths would not be visible when querying with forward slash paths, or vice versa. Related to PR anomalyco#17067 by HRronaldo Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
github-actions
bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
These appear to be related PRs tackling the same core issue. The current PR (#19645) may be building on or superseding #17067. |
Also normalize Windows drive letters to uppercase for consistent path matching. This ensures paths like 'c:/path' and 'C:/path' are treated the same.
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Windows session list display issues where sessions become invisible due to path separator inconsistencies.
Changes
Issues Fixed
Closes #16744
Closes #18029
This fixes the Windows path issue where sessions created with backslash paths would not be visible when querying with forward slash paths, or vice versa.
Related to PR #17067 by HRronaldo