Skip to content

refactor(project): load icons from .opencode assets#16929

Open
anduimagui wants to merge 7 commits intoanomalyco:devfrom
anduimagui:feat/icon-loading-config-clean
Open

refactor(project): load icons from .opencode assets#16929
anduimagui wants to merge 7 commits intoanomalyco:devfrom
anduimagui:feat/icon-loading-config-clean

Conversation

@anduimagui
Copy link

@anduimagui anduimagui commented Mar 10, 2026

Issue for this PR

Closes #

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

The new resolution behavior prioritizes icon files inside .opencode/icon/ first, then falls back to .opencode/**/favicon.*, and then keeps discovery fallback for repository favicon files. It also adds support for .url files (direct URL/data URL or URL=... format).

How did you verify your code works?

  • Updated tests in packages/opencode/test/project/project.test.ts for .opencode icon priority behavior.
  • Removed config-schema tests that validated icon in opencode.json.
  • Ran:
    • bun test test/project/project.test.ts test/config/config.test.ts (from packages/opencode)
  • In this environment, test execution is currently blocked by local git hook/tooling behavior in temp repos (lefthook/mint command failures), so full local verification is incomplete.

Screenshots / recordings

If this is a UI change, please include a screenshot or recording.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@github-actions github-actions bot added the needs:compliance This means the issue will auto-close after 2 hours. label Mar 10, 2026
@github-actions github-actions bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Mar 10, 2026
@github-actions
Copy link
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@anduimagui anduimagui marked this pull request as ready for review March 11, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant