fix: keep Copilot Claude prompts user-final across continuation turns#16921
Open
sryantich wants to merge 3 commits intoanomalyco:devfrom
Open
fix: keep Copilot Claude prompts user-final across continuation turns#16921sryantich wants to merge 3 commits intoanomalyco:devfrom
sryantich wants to merge 3 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #12337
Type of change
What does this PR do?
Issue #12337 reports GitHub Copilot Claude / Opus 4.6 failing with "This model does not support assistant message prefill. The conversation must end with a user message."
In opencode, that can happen when the autonomous loop continues after an assistant response or tool phase and the prompt sent to Copilot Claude still ends on a non-user turn. The max-step path could also reintroduce the same shape by appending an assistant-final message.
This change fixes that in two places. The session prompt loop now keeps Anthropic-style and Copilot Claude prompts user-final when it needs to continue, including the max-step edge case.
ProviderTransformalso adds a narrow last-line repair for providers that require user-final prompts, so Copilot Claude does not receive an assistant-final or tool-final transcript even if one slips through earlier prompt construction. The tests cover the prompt helper, the provider transform, and the Copilot message serializer.How did you verify your code works?
cd packages/opencode && bun test --timeout 30000cd packages/opencode && bun run typecheckScreenshots / recordings
Not a UI change.
Checklist