fix(app): focus terminal when panel opens via toggle shortcut#16799
Open
anduimagui wants to merge 3 commits intoanomalyco:devfrom
Open
fix(app): focus terminal when panel opens via toggle shortcut#16799anduimagui wants to merge 3 commits intoanomalyco:devfrom
anduimagui wants to merge 3 commits intoanomalyco:devfrom
Conversation
The focus effect only triggered when terminal.active() changed, not when the panel opened. This meant if a terminal was already active (restored from previous session), toggling the panel open wouldn't shift focus from the chat input to the terminal. Added a new effect that watches panel.open() and focuses the active terminal whenever the panel transitions from closed to open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #12637
Type of change
What does this PR do?
Fixes a bug where toggling the terminal panel open via keyboard shortcut would not shift focus from the chat input to the terminal when a terminal was already active (e.g., restored from a previous session).
Root Cause: The focus effect in
terminal-panel.tsxonly triggered whenterminal.active()changed value. When the panel was toggled open but the active terminal ID remained the same, no focus shift occurred.Fix: Added a new effect that watches
panel.open()and focuses the active terminal whenever the panel transitions from closed to open, regardless of whether the active terminal changed.How did you verify your code works?
Screenshots / recordings
N/A - focus behavior change
Checklist