fix(plugin): support subpath imports in plugin specifiers#16791
Open
oritwoen wants to merge 4 commits intoanomalyco:devfrom
Open
fix(plugin): support subpath imports in plugin specifiers#16791oritwoen wants to merge 4 commits intoanomalyco:devfrom
oritwoen wants to merge 4 commits intoanomalyco:devfrom
Conversation
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Plugins can now use subpath exports (e.g. "websxa/opencode") instead of
requiring a dedicated wrapper package. The specifier is parsed into package
name and subpath, installed via BunProc.install, then the subpath is resolved
through the package's exports map.
Handles unscoped ("pkg/sub"), scoped ("@scope/pkg/sub"), and versioned
("pkg/sub@1.0.0") specifiers. Falls back to direct path when no exports
map exists. Fully backward compatible with existing specifier formats.
oritwoen
force-pushed
the
fix/plugin-subpath-imports
branch
from
a22eb90 to
0acfa58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16792
Type of change
What does this PR do?
The plugin loader passes the full specifier string to
BunProc.install(). For"websxa/opencode", that means it tries to install a package literally calledwebsxa/opencode, which doesn't exist. The actual package iswebsxawith a./opencodesubpath export.This adds a
parsePluginSpecifier()function that splits the specifier into package name, subpath, and version. After installing the base package, the subpath gets resolved through the package'sexportsmap inpackage.json. Falls back to direct path join for packages without an exports map.Handles all specifier shapes:
pkg,pkg/sub,pkg@1.0.0,pkg/sub@1.0.0,@scope/pkg/sub,@scope/pkg/sub@1.0.0.Fully backward compatible since specifiers without subpaths parse to the same values as before.
How did you verify your code works?
Tested parsing logic against all specifier formats (unscoped, scoped, versioned, deep subpaths). Tested exports map resolution against a real
package.jsonwith nested export conditions (import,default). Verified existing specifiers without subpaths still resolve correctly.Screenshots / recordings
N/A, no UI changes.
Checklist