feat: FastTransfer v0.6.0 & FastBCP v0.7.0 - New parameters, methods, and comprehensive documentation#2
Open
PierreAntoineAP wants to merge 36 commits intoaetperf:masterfrom
Open
feat: FastTransfer v0.6.0 & FastBCP v0.7.0 - New parameters, methods, and comprehensive documentation#2PierreAntoineAP wants to merge 36 commits intoaetperf:masterfrom
PierreAntoineAP wants to merge 36 commits intoaetperf:masterfrom
Conversation
…ndling, and streamline release file preparation
…d refine build steps
…2022, assembly signé)
…80F1 avec assemblies signés
…DrivenQuery, noBanner, Physloc, NZDataSlice
…ion, config, nobanner + méthode Timepartition
…tion post-installation
…iption debug mode
… et FastBCP_Executor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+86
to
+90
| CREATE PROCEDURE [dbo].[xp_RunFastTransfer_secure] | ||
| @fastTransferDir [nvarchar](max), | ||
| @sourceConnectionType [nvarchar](30), | ||
| @sourceConnectStringSecure [nvarchar](4000) = N'', | ||
| @sourceServer [nvarchar](255), |
| if (!string.IsNullOrEmpty(applicationintentVal) && | ||
| (connType == "mssql" || connType == "oledb" || connType == "msoledbsql")) | ||
| { | ||
| args.Append(" --applicationintent ").Append(applicationintentVal); |
Comment on lines
+38
to
+46
| # Check for DACPAC in bin\Output (SQL Projects output here) | ||
| $dacpacPath = "bin\Output\FastWrappers_TSQL.dacpac" | ||
| if (Test-Path $dacpacPath) { | ||
| Write-Host "DACPAC found at: $dacpacPath" | ||
| } else { | ||
| Write-Host "DACPAC not found at: $dacpacPath" | ||
| Write-Host "Looking for .dacpac files..." | ||
| Get-ChildItem -Path . -Filter "*.dacpac" -Recurse -ErrorAction SilentlyContinue | Format-Table FullName | ||
| exit 1 |
| 4. **Deploy** temporarily to SQL LocalDB | ||
| 5. **Generate** artifacts: | ||
| - BACPAC via SqlPackage export | ||
| - BAK via BACKUP DATABASE (with compression) |
more generic version numer Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
|
@PierreAntoineAP : regarde les remarques du copilot reviewer, il me semble qu'il y a quelques changements à prévoir avant le merge |
…ub Action - Modification de la GitHub Action pour extraire le binaire de l'assembly depuis la base déployée - Création d'un nouveau template FastWrappers-TSQL.sql avec placeholder __ASSEMBLY_FROM_0X__ - Le binaire est injecté automatiquement pendant le build - Utilise sp_add_trusted_assembly pour plus de sécurité - Crée la base de données, l'assembly, les SP (FastTransfer et FastBCP) et les roles - Script complet prêt à l'emploi avec vérifications
…ode C# - Ajout de tous les paramètres manquants (outputFile, outputDirectory, usequotes, etc.) - Correction des noms de paramètres pour correspondre exactement à la signature C# - Ordre des paramètres respecté selon FastBCPWrapper_SP.cs.cs
… FastWrappers-TSQL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.