fix: Support range sliders in usePreventScroll on iOS#9506
fix: Support range sliders in usePreventScroll on iOS#9506yihuiliao merged 2 commits intoadobe:mainfrom
Conversation
|
I also signed the CLA after seeing that failure if someone wants to re-run |
There was a problem hiding this comment.
Thanks for the PR. This is going to be tricky. I went to the story in the testing instructions, and if i vertically drag, starting on the slider, then I can scroll the page, which is not intended.
@devongovett were you ok with that as a potential side effect? It seems uncommon that people wouldn't stumble on it.
I'm a little unclear on when precisely this is an issue. Where is usePreventScroll being used that it's blocking a range input in your application? It shouldn't be a problem if the input is inside a modal which is most of the cases where scrolling is prevented.
|
try to refresh CLA bot |
|
@snowystinger there are already cases where we cannot prevent scroll such as text selection. This is another edge case we need to allow. I don't think it's possible to be completely perfect unfortunately. |

Closes #9493
✅ Pull Request Checklist:
Updated documentation (if it already exists for this component)📝 Test Instructions:
usePreventScrollstory on iOS device