Skip to content

Conversation

@makermelissa
Copy link
Collaborator

@makermelissa makermelissa commented Dec 11, 2025

Fixes #13. I also found and fixed a couple of bugs while testing on a bar display including:

  • If a display has no touchscreen, it was failing to initialize
  • Incorrect touch transformation on displays where height and width differed

@makermelissa makermelissa requested a review from a team December 11, 2025 20:40
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look correct and fix #13

self._touch.rotation = value
# Update the display rotation if already initialized
if self.display is not None:
if self.display:
Copy link
Member

@brentru brentru Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ OK to change, you are simply checking object existence

@makermelissa makermelissa merged commit 2aa4614 into adafruit:main Dec 11, 2025
1 check passed
adafruit-adabot pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default Rotation in Docstrings Incorrect?

2 participants