-
-
Notifications
You must be signed in to change notification settings - Fork 697
Add Lua rockspec package handler for LuaRocks dependencies #4743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
f9324f8
af15759
d106e92
dc4fc99
99cd99f
3b359de
9a0cd5f
4103a81
d7b5fbd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,6 +42,7 @@ jsonstreams==0.6.0 | |
| keyring==23.7.0 | ||
| license-expression==30.4.4 | ||
| lxml==6.0.2 | ||
| luaparser==4.0.0 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is also installing two new dependencies, can you also add these here? |
||
| MarkupSafe==3.0.3 | ||
| more-itertools==10.8.0 | ||
| multiregex==2.0.3 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,6 +91,7 @@ install_requires = | |
| jsonstreams >= 0.5.0 | ||
| license_expression >= 30.4.4 | ||
| lxml >= 5.4.0 | ||
| luaparser == 4.0.0 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's not pin dependencies, you can add this as a lower bound. We are a library too :) |
||
| MarkupSafe >= 2.1.2 | ||
| multiregex >= 2.0.3 | ||
| normality <= 2.6.1 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching and fixing this!