Skip to content

[AIT-553] Update to ably-js 2.20.0 in examples and use new subscription fields#3275

Merged
VeskeR merged 1 commit intomainfrom
AIT-553/lo-examples-use-2.20.0
Mar 17, 2026
Merged

[AIT-553] Update to ably-js 2.20.0 in examples and use new subscription fields#3275
VeskeR merged 1 commit intomainfrom
AIT-553/lo-examples-use-2.20.0

Conversation

@VeskeR
Copy link
Contributor

@VeskeR VeskeR commented Mar 13, 2026

Resolves AIT-553

Description

Checklist

@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ab006e5e-dc0d-4f82-8864-3565a2eb879f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch AIT-553/lo-examples-use-2.20.0
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@VeskeR VeskeR added the review-app Create a Heroku review app label Mar 13, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-ait-553-lo-ex-gxgi6q March 13, 2026 13:24 Inactive
@VeskeR VeskeR force-pushed the AIT-553/lo-examples-use-2.20.0 branch from decaa20 to ad2944d Compare March 13, 2026 13:24
@VeskeR VeskeR changed the title [AIT-553] Update to ably-js 2.20.0 in examples and use subscription fields [AIT-553] Update to ably-js 2.20.0 in examples and use new subscription fields Mar 13, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-ait-553-lo-ex-gxgi6q March 13, 2026 13:24 Inactive
@VeskeR VeskeR requested review from m-hulbert and removed request for GregHolmes March 13, 2026 13:36
@VeskeR
Copy link
Contributor Author

VeskeR commented Mar 13, 2026

@m-hulbert example page in the preview app https://ably-docs-ait-553-lo-ex-gxgi6q.herokuapp.com/examples/liveobjects-live-map?lang=javascript doesn't seem to use the latest ably-js version specified in this PR (2.20.0) - the protocol version used is still 5 in the preview app (should be 6). Did I do something wrong and need to update something else?

Copy link
Contributor

@lawrence-forooghian lawrence-forooghian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will leave with you to sort out the build issues

@m-hulbert m-hulbert temporarily deployed to ably-docs-ait-553-lo-ex-gxgi6q March 16, 2026 17:49 Inactive
@m-hulbert
Copy link
Contributor

@m-hulbert example page in the preview app https://ably-docs-ait-553-lo-ex-gxgi6q.herokuapp.com/examples/liveobjects-live-map?lang=javascript doesn't seem to use the latest ably-js version specified in this PR (2.20.0) - the protocol version used is still 5 in the preview app (should be 6). Did I do something wrong and need to update something else?

Annoyingly you need to update it in the renderer too - just pushed a fixup that should have sorted it when the review app rebuilds @VeskeR

@VeskeR
Copy link
Contributor Author

VeskeR commented Mar 17, 2026

Annoyingly you need to update it in the renderer too - just pushed a fixup that should have sorted it when the review app rebuilds @VeskeR

Thanks, will keep in mind

@VeskeR VeskeR force-pushed the AIT-553/lo-examples-use-2.20.0 branch from f1cc9a3 to 7d02cea Compare March 17, 2026 16:57
@VeskeR VeskeR force-pushed the AIT-553/lo-examples-use-2.20.0 branch from 7d02cea to f59ecbc Compare March 17, 2026 16:58
@ably-ci ably-ci temporarily deployed to ably-docs-ait-553-lo-ex-gxgi6q March 17, 2026 16:58 Inactive
@VeskeR VeskeR enabled auto-merge March 17, 2026 16:58
@VeskeR VeskeR merged commit c19457e into main Mar 17, 2026
6 of 7 checks passed
@VeskeR VeskeR deleted the AIT-553/lo-examples-use-2.20.0 branch March 17, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

4 participants