ait: update python token streamin async patterns#3269
Open
owenpearson wants to merge 1 commit intomainfrom
Open
ait: update python token streamin async patterns#3269owenpearson wants to merge 1 commit intomainfrom
owenpearson wants to merge 1 commit intomainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f9e5541 to
7f44e1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bugs with asyncio/coroutine usage in python examples in the AIT docs where coroutines were created but never actually started. this meant that in some cases coroutines were created and then all executed at once using
asyncio.gather, and in some cases coroutines weren't started at all. the most common way to create a coroutine and start it immediately is by wrapping the coroutine in a call toasyncio.create_task, so this PR updates all AIT python examples to do that.I've tested the new examples with standalone python scripts and verified that they work correctly.
AIT-550