Skip to content

Conversation

@splindsay-92
Copy link
Contributor

Description

It was a bit unclear how persistence is managed for chat, so I've added a few lines to highlight how this works.

Checklist

@coderabbitai
Copy link

coderabbitai bot commented Dec 17, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.


### Message persistence <a id="persistence"/>

The `::$chat` suffix applied to chat room channels enables intrinsic default behaviors that differ from standard Pub/Sub channels. One of the most important behaviors is message persistence.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This para is probably too much detail for the docs, I think we can remove it and let the following two do the talking.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@splindsay-92 I dont think this one is resolved? Im suggesting that we don't need to explain how the mechanism works here - too much info and for those interested is implied by the paragraphs above and below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndyTWF Sorry about that, I was sure I'd pushed a commit to remove this! dd82756

@splindsay-92 splindsay-92 force-pushed the chat/clearly-list-defualt-channel-behaviour branch 2 times, most recently from 5f7945a to c30b165 Compare January 5, 2026 17:47
@splindsay-92 splindsay-92 force-pushed the chat/clearly-list-defualt-channel-behaviour branch from c30b165 to dd82756 Compare January 7, 2026 15:44
@splindsay-92 splindsay-92 force-pushed the chat/clearly-list-defualt-channel-behaviour branch from dd82756 to a14eafc Compare January 8, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants