fix: packaging issue for generated /sync files#646
Conversation
WalkthroughRefines Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b89dfe2 to
75ca2e3
Compare
There was a problem hiding this comment.
I think we should include the previous note regarding usage of the sync REST API in README.md.
https://github.com/ably/ably-python/tree/v2.0.9?tab=readme-ov-file#using-the-rest-api
Seems usage for the same not present in official doc : \ (You can double check)
UV respects `.gitgnore` by default and excludes generated `/sync` files from built packages. In this PR we explicitly specify files that should be packed and ignore vcs
75ca2e3 to
65e5bc1
Compare
UV respects
.gitgnoreby default and excludes generated/syncfiles from built packages.In this PR we explicitly specify files that should be packed and ignore vcs
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.