-
Notifications
You must be signed in to change notification settings - Fork 42
Release/1.6.0 #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.6.0 #1185
Conversation
WalkthroughAdds a 1.6.0 release: updates version references, adds a changelog entry describing experimental Mutable Message REST and Realtime behavior changes and migration guidance, and updates a test expectation to the new agent version. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@CHANGELOG.md`:
- Line 28: Fix the grammatical error in the CHANGELOG entry referencing
updateMessage(), deleteMessage(), and appendMessage(): change "are now use
WebSocket transport to send data rather than REST requests" to "now use
WebSocket transport to send data rather than REST requests" so the sentence
reads correctly while keeping the function names and meaning unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@CHANGELOG.md`:
- Around line 9-11: The CHANGELOG contains bare URLs that trigger markdownlint
MD034; update each bare link (e.g., the URLs for PRs
"https://github.com/ably/ably-java/pull/1182",
"https://github.com/ably/ably-java/pull/1183", and
"https://github.com/ably/ably-java/pull/1184") to use inline markdown link
syntax (for example replace the raw URL with a descriptive link like
[`#1182`](https://github.com/ably/ably-java/pull/1182) or [Message Updates and
Deletes PR](https://github.com/ably/ably-java/pull/1182)) so the changelog lines
read without bare URLs and satisfy MD034.
♻️ Duplicate comments (1)
CHANGELOG.md (1)
28-28: Fix grammar: “are now use” → “now use”.
This is already flagged in a previous review; please apply the suggested wording.📝 Proposed fix
-* `updateMessage()`, `deleteMessage()`, and `appendMessage()` are now use WebSocket transport to send data rather than REST requests +* `updateMessage()`, `deleteMessage()`, and `appendMessage()` now use WebSocket transport to send data rather than REST requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@CHANGELOG.md`:
- Around line 32-43: Update the "Before (v1.5.0)" example to use the original
CompletionListener type and its parameterless onSuccess signature instead of
Callback<UpdateDeleteResult>; specifically change the callback passed to
channel.updateMessageAsync in the before-example from
Callback<UpdateDeleteResult> to CompletionListener and ensure the onSuccess
method has no parameters (add `@Override` if presentationally desired) so the
example matches the described migration from CompletionListener to
Callback<UpdateDeleteResult>.
- Around line 45-56: The "Before (v1.5.0)" examples incorrectly show
Callback<UpdateDeleteResult> instead of the previous CompletionListener; update
both REST and Realtime "Before" snippets to use CompletionListener (e.g.,
channel.updateMessageAsync(..., new CompletionListener() { public void
onSuccess() { ... } })) and ensure the "After (v1.6.0)" examples remain using
Callback<UpdateDeleteResult> (e.g., channel.updateMessage or
channel.updateMessageAsync with Callback<UpdateDeleteResult> and
onSuccess(UpdateDeleteResult result)).
sacOO7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's Changed
publish#1184Summary by CodeRabbit
Documentation
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.