Skip to content

Conversation

@marcellourbani
Copy link
Collaborator

@larshp I finally found the time to fix this.
Single file rules are mostly working now. Notes:

  • some changes are adt specific. Perhaps I should use !== file rather than === "adt" but it's by far the most common case
  • the glob stuff is not ideal, but unless we call an extension specific API is the best we can do
  • the file search stuff is not strictly related but should work. Was converting / to //
  • tasks and run configurations are unrelated but I hate working without a debugger, or restarting the whole thing on every change. With this reloading the window is enough
  • there are several type errors, mostly due to version misalignment with core. I fixed a few (not entirely sure about a couple) and ignored others for getting a debuggable build
  • all tests pass, formatting.ts is definitely broken anyway

@marcellourbani
Copy link
Collaborator Author

weird, I had to revert my last commit to make tests pass here...

@larshp larshp changed the title Marcellourbani/issue189 check for adt remote filesystem Jan 5, 2026
@larshp
Copy link
Member

larshp commented Jan 5, 2026

thanks

@larshp larshp merged commit a554e00 into abaplint:main Jan 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants