Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/a2a/client/__init__.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
"""Client-side components for interacting with an A2A agent."""

import logging

from a2a.client.auth import (
AuthInterceptor,
CredentialService,
Expand All @@ -26,9 +24,6 @@
from a2a.client.interceptors import ClientCallInterceptor


logger = logging.getLogger(__name__)


__all__ = [
'A2ACardResolver',
'A2AClientError',
Expand Down
2 changes: 0 additions & 2 deletions src/a2a/client/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,6 @@ async def consume(
card: AgentCard,
) -> None:
"""Processes the event via all the registered `Consumer`s."""
if not event:
return
for c in self._consumers:
await c(event, card)

Expand Down
10 changes: 3 additions & 7 deletions src/a2a/client/client_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ def rest_transport_producer(
'You can install them with \'pip install "a2a-sdk[grpc]"\''
)

_grpc_transport = GrpcTransport

def grpc_transport_producer(
card: AgentCard,
url: str,
Expand All @@ -203,13 +205,7 @@ def grpc_transport_producer(
):
return CompatGrpcTransport.create(card, url, config)

if GrpcTransport is not None:
return GrpcTransport.create(card, url, config)

raise ImportError(
'GrpcTransport is not available. '
'You can install it with \'pip install "a2a-sdk[grpc]"\''
)
return _grpc_transport.create(card, url, config)

self.register(
TransportProtocol.GRPC,
Expand Down
4 changes: 1 addition & 3 deletions src/a2a/server/request_handlers/grpc_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -393,9 +393,7 @@ async def abort_context(
domain='a2a-protocol.org',
)

status_code = (
code.value[0] if code else grpc.StatusCode.UNKNOWN.value[0]
)
status_code = code.value[0]
error_msg = (
error.message if hasattr(error, 'message') else str(error)
)
Expand Down
3 changes: 0 additions & 3 deletions tests/client/test_auth_interceptor.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,6 @@ class AuthTestCase:

@pytest.mark.skip(reason='Interceptors disabled by user request')
@pytest.mark.asyncio
@pytest.mark.skip(
reason='Interceptors not explicitly being tested as per use request'
)
@pytest.mark.parametrize(
'test_case',
[api_key_test_case, oauth2_test_case, oidc_test_case, bearer_test_case],
Expand Down
13 changes: 4 additions & 9 deletions tests/server/request_handlers/test_default_request_handler.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import asyncio
import contextlib
import logging
import uuid
import time
import uuid
from typing import cast

from typing import cast
from unittest.mock import (
AsyncMock,
MagicMock,
Expand Down Expand Up @@ -34,7 +33,6 @@
TaskStore,
TaskUpdater,
)

from a2a.types import (
InternalError,
InvalidParamsError,
Expand All @@ -43,29 +41,26 @@
TaskNotFoundError,
UnsupportedOperationError,
)

from a2a.types.a2a_pb2 import (
Artifact,
CancelTaskRequest,
DeleteTaskPushNotificationConfigRequest,
GetTaskPushNotificationConfigRequest,
GetTaskRequest,
ListTaskPushNotificationConfigsRequest,
ListTasksRequest,
ListTasksResponse,
ListTaskPushNotificationConfigsRequest,
Message,
Part,
TaskPushNotificationConfig,
Role,
SendMessageConfiguration,
SendMessageRequest,
TaskPushNotificationConfig,
SubscribeToTaskRequest,
Task,
TaskPushNotificationConfig,
TaskState,
TaskStatus,
TaskStatusUpdateEvent,
CancelTaskRequest,
SubscribeToTaskRequest,
)
from a2a.utils import new_agent_text_message, new_task

Expand Down
9 changes: 1 addition & 8 deletions tests/server/test_integration.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import asyncio

from typing import Any
from unittest import mock

import pytest

from starlette.authentication import (
AuthCredentials,
AuthenticationBackend,
Expand All @@ -18,16 +15,14 @@
from starlette.routing import Route
from starlette.testclient import TestClient

from a2a.server.routes import create_agent_card_routes, create_jsonrpc_routes

from a2a.server.context import ServerCallContext
from a2a.server.jsonrpc_models import (
InternalError,
InvalidParamsError,
InvalidRequestError,
JSONParseError,
MethodNotFoundError,
)
from a2a.server.routes import create_agent_card_routes, create_jsonrpc_routes
from a2a.types import (
UnsupportedOperationError,
)
Expand All @@ -39,9 +34,7 @@
Artifact,
Message,
Part,
TaskPushNotificationConfig,
Role,
SendMessageResponse,
Task,
TaskArtifactUpdateEvent,
TaskPushNotificationConfig,
Expand Down
Loading