Skip to content

[Fix] BaseViewController TabBar Hidden 조건 추가 #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
choijungp wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Fix] BaseViewController TabBar Hidden 조건 추가 #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions Projects/Presentation/Sources/Common/Protocol/BaseViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,15 @@ public class BaseViewController<T: ViewModel>: UIViewController {
let viewModel: T
private var baseCancellables = Set<AnyCancellable>()
private lazy var networkErrorView = NetworkErrorView()
private var isShowingNetworkError = false

var isShowingTabBar: Bool { true }

init(viewModel: T) {
self.viewModel = viewModel
super.init(nibName: nil, bundle: nil)
}

deinit {
guard isShowingNetworkError else { return }
guard isShowingTabBar else { return }

DispatchQueue.main.async { [weak tabBarController = self.tabBarController] in
tabBarController?.tabBar.isHidden = false
Expand Down Expand Up @@ -78,15 +77,15 @@ public class BaseViewController<T: ViewModel>: UIViewController {

/// 네트워크 에러 뷰 를 보이거나 숨깁니다.
private func handleNetworkErrorView(show: Bool) {
isShowingNetworkError = show

if show {
view.bringSubviewToFront(networkErrorView)
networkErrorView.isHidden = false
tabBarController?.tabBar.isHidden = true
} else {
networkErrorView.isHidden = true
tabBarController?.tabBar.isHidden = false
if isShowingTabBar {
tabBarController?.tabBar.isHidden = false
}
}
}
}
1 change: 1 addition & 0 deletions ...tation/Sources/ResultRecommendedRoutine/View/ResultRecommendedRoutineViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ final class ResultRecommendedRoutineViewController: BaseViewController<ResultRec
static let skipButtonBottomSpacing: CGFloat = 20
}

override var isShowingTabBar: Bool { false }
private let mainLabel = UILabel()
private var subLabel = UILabel()
private let recommendedRoutineStackView = UIStackView()
Expand Down
Loading