Conversation
워크스루세 개의 뷰 컨트롤러와 커스텀 뷰에서 UI 레이아웃 및 스타일링 업데이트를 진행했습니다. 스피치 레이블의 폰트 패밀리를 cafe24Ssurround로 변경하고, 하단 여백 제약 조건을 추가했으며, 분할선의 제약 조건 관리 방식을 개선했습니다. 변경 사항
예상 코드 리뷰 노력🎯 2 (Simple) | ⏱️ ~10분 시
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
Projects/Presentation/Sources/RoutineCreation/View/Component/RoutineCreationCardView.swift (1)
170-173: 초기 오프셋에CGFloat.zero대신0을 사용하는 것을 고려해 보세요.
CGFloat.zero는 동작상 문제는 없지만, Line 258에서Layout.edgeSpacing을 사용하는 것과 대칭적으로Layout.divideLineTopSpacing같은 상수를 사용하거나, 간결하게0을 쓰는 것이 일관성 면에서 더 좋습니다. 또한 Line 265의 collapse 시에도 동일하게CGFloat.zero가 사용되고 있습니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Projects/Presentation/Sources/RoutineCreation/View/Component/RoutineCreationCardView.swift` around lines 170 - 173, Replace the uses of CGFloat.zero for the divide line top offset with a consistent constant or a plain 0: update the constraint creation where divideLineTopConstraint is set relative to labelStackView.snp.bottom to use either Layout.divideLineTopSpacing (or a new Layout constant e.g., Layout.divideLineTopSpacing) or simply 0, and make the same change where the constraint is modified on collapse (the other place that currently uses CGFloat.zero) so both places use the same concise constant.Projects/Presentation/Sources/EmotionRegister/View/EmotionRegistrationViewController.swift (1)
128-131:style:뒤에 공백이 누락되었습니다.Line 130에서
style:.cafe24Title2→style: .cafe24Title2로 수정하면 다른 파라미터와 일관된 포맷이 됩니다.🔧 수정 제안
speechLabel.font = BitnagilFont.init( family: .cafe24Ssurround, - style:.cafe24Title2, + style: .cafe24Title2, weight: .light).font🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Projects/Presentation/Sources/EmotionRegister/View/EmotionRegistrationViewController.swift` around lines 128 - 131, The formatting of the BitnagilFont initializer call is inconsistent: in the speechLabel.font assignment (BitnagilFont.init) change the parameter formatting from "style:.cafe24Title2" to "style: .cafe24Title2" so it matches the other parameters (family: and weight:) and keeps consistent spacing around colons.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@Projects/Presentation/Sources/EmotionRegister/View/EmotionRegistrationViewController.swift`:
- Around line 128-131: The formatting of the BitnagilFont initializer call is
inconsistent: in the speechLabel.font assignment (BitnagilFont.init) change the
parameter formatting from "style:.cafe24Title2" to "style: .cafe24Title2" so it
matches the other parameters (family: and weight:) and keeps consistent spacing
around colons.
In
`@Projects/Presentation/Sources/RoutineCreation/View/Component/RoutineCreationCardView.swift`:
- Around line 170-173: Replace the uses of CGFloat.zero for the divide line top
offset with a consistent constant or a plain 0: update the constraint creation
where divideLineTopConstraint is set relative to labelStackView.snp.bottom to
use either Layout.divideLineTopSpacing (or a new Layout constant e.g.,
Layout.divideLineTopSpacing) or simply 0, and make the same change where the
constraint is modified on collapse (the other place that currently uses
CGFloat.zero) so both places use the same concise constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👩💻 Contents
Summary by CodeRabbit