proxy/proxy.go: allow splice thru HTTPUpgrade #5470
Closed
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTPUpgrade encapsulates a raw TCP, so it can be spliced.
Member
|
Thanks @LGA1150 . Have you tested it? If so, can you ellaborate? |
Author
|
好像有问题，开 debug log 显示启用了 splice，但是 strace 没看到。。 |
Member
|
这样没用吧 要触发tcp splice需要它的readfrom检测出给的reader是 net.TCPConn 这样子搞哪怕是给进去最后会发现是 ConnRF 会退化为普通copy |
Author
|
知道了，需要把 ConnRF 内部的 conn 提出来才可以 splice，不过我不知道怎么改比较合适了 |
Member
|
需要加一个像xtls切换那样的逻辑 我觉得不是很划得来 因为这是客户端部分 瓶颈不在这 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTPUpgrade encapsulates a raw TCP, so it can be spliced.