-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Remove redundant stats in mux and bridge dispatcher #5466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
这样改的话似乎会影响 @wyx2685 |
|
居然被@了 |
|
我理解不在 dispatch 时候 cast dispatcher 就行 既然要删掉 那顺便 refactor |
|
这里对于自定义的 DefaultDispatcher 会有类型兼容性问题的 这是上一次 @Fangliding 风筝当时做的兼容性重构。 f9dd3ae#diff-35b30f4c19a774a865d83f273a0a5f8a6925c96d6c3f4e6bbf2aaca850705b62R78-R93 重构 type Handler struct {
// ...
dispatcher routing.WrapLinkDispatcher
// ...
} handler := &Handler{
// ...
dispatcher: v.GetFeature(routing.DispatcherType()).(routing.WrapLinkDispatcher),
// ...
} if request.Command == protocol.RequestCommandRvs {
r, err := h.GetReverse(account)
if err != nil {
return err
}
return r.NewMux(ctx, h.dispatcher.WrapLink(ctx, &transport.Link{Reader: clientReader, Writer: clientWriter}))
} |
This reverts commit f9dd3ae.
Since mux will add traffic stats in sub connection's dispatch function Adding additional stats result to double counting
|
@xtlsee 行吧 给你改成 interface 了 |
|
@yuhan6665 牛逼,大神。优雅 |
|
|
Fix #5446
I'm not sure about vless inbound calling WrapLink() for RequestCommandRvs.
Please take a look @Fangliding @RPRX