Skip to content

Comments

Update wp.sanitize.stripTags() to return empty string when not passed a string#10994

Open
westonruter wants to merge 1 commit intoWordPress:trunkfrom
westonruter:update/wp-sanitize-strip-tags-non-strings
Open

Update wp.sanitize.stripTags() to return empty string when not passed a string#10994
westonruter wants to merge 1 commit intoWordPress:trunkfrom
westonruter:update/wp-sanitize-strip-tags-non-strings

Conversation

@westonruter
Copy link
Member

@westonruter westonruter commented Feb 20, 2026

See #10833 (comment):

I’m late to the game, but do we expect any other type errors? I suppose we expect people to send things that are strings nominally, but may be missing.

However, if we make a positive assertion we wouldn’t have to chase this later.

if ( 'string' !== typeof $text ) {
	return '';
}

It turns out that passing a non-string in 6.9 would cause an error due to the replace() method not being available on it (probably). So the previous change in r61578 which added support for sanitizing numbers actually would have previously caused an error. So we can indeed just short-circuit when a non-string is passed.

Trac ticket: https://core.trac.wordpress.org/ticket/64574

Follow-up to:

Use of AI Tools

None


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

… a string

Co-authored-by: Dennis Snell <dmsnell@git.wordpress.org>
@westonruter westonruter requested a review from dmsnell February 20, 2026 21:58
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter
Copy link
Member Author

@Hug0-Drelon How does this work for you?

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant