Fix PHPStan level 0 issues for Customizer setting subclasses by returning correct types#10952
Fix PHPStan level 0 issues for Customizer setting subclasses by returning correct types#10952westonruter wants to merge 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
@justlevine Would you give this a review for me? |
peterwilsoncc
left a comment
There was a problem hiding this comment.
This looks good to me and is testing well:
Testing notes:
- Activate 2014
- Add header image
- Confirm
- Remove header image
- Confirm
- Add a menu
- Place it in header (primary)
- confirm
- Add items to menu
- confirm
Confirm indicates:
- dynamically updated in the customizer
- saved when publish button hit
- displayed on front end after hitting publsih
…ides return consistent types. This addresses PHPStan type check issues. Developed in #10952 Props westonruter, peterwilsoncc, justlevine. See #64238, #61175. git-svn-id: https://develop.svn.wordpress.org/trunk@61670 602fd350-edb4-49c9-b593-d223f7449a82
…ides return consistent types. This addresses PHPStan type check issues. Developed in WordPress/wordpress-develop#10952 Props westonruter, peterwilsoncc, justlevine. See #64238, #61175. Built from https://develop.svn.wordpress.org/trunk@61670 git-svn-id: http://core.svn.wordpress.org/trunk@60978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The changes in this PR were cherry-picked (e.g. 2f72407 and 22370b6) from #10419 for Core-61175.
This Customizer ensures return type consistency for the update methods for setting classes. In practice, these methods are protected and the return value is never read, so it's just about housekeeping. It keeps the overridden methods compatible with the parent class's method.
Trac ticket: https://core.trac.wordpress.org/ticket/64238
Use of AI Tools
n/a
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.