Skip to content

Comments

64623 prevent losing data when clicking links on settings page#10940

Closed
nirav7707 wants to merge 3 commits intoWordPress:trunkfrom
nirav7707:64623-prevent-losing-data-when-clicking-links-on-settings-page
Closed

64623 prevent losing data when clicking links on settings page#10940
nirav7707 wants to merge 3 commits intoWordPress:trunkfrom
nirav7707:64623-prevent-losing-data-when-clicking-links-on-settings-page

Conversation

@nirav7707
Copy link

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props niravsherasiya7707.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@westonruter
Copy link
Member

Thank you for the PR, but this isn't the right approach. The alert needs to only be shown when there are unsaved changes, and it needs to show when navigating away from an admin screen by any means (including the use of the back button). Please offer suggestions to the existing PR: #10927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants