64623 prevent losing data when clicking links on settings page#10940
64623 prevent losing data when clicking links on settings page#10940nirav7707 wants to merge 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Thank you for the PR, but this isn't the right approach. The alert needs to only be shown when there are unsaved changes, and it needs to show when navigating away from an admin screen by any means (including the use of the back button). Please offer suggestions to the existing PR: #10927 |
Core ticket: https://core.trac.wordpress.org/ticket/64623