-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Update build_query_vars_from_query_block to handle new taxQuery structure
#10632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Update build_query_vars_from_query_block to handle new taxQuery structure
#10632
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| $exclude_terms = isset( $tax_query_input['exclude'] ) && is_array( $tax_query_input['exclude'] ) | ||
| ? $tax_query_input['exclude'] | ||
| : array(); | ||
| $include_terms = isset( $tax_query_input['include'] ) && is_array( $tax_query_input['include'] ) | ||
| ? $tax_query_input['include'] | ||
| : array(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation doesn't seem quite right:
| $exclude_terms = isset( $tax_query_input['exclude'] ) && is_array( $tax_query_input['exclude'] ) | |
| ? $tax_query_input['exclude'] | |
| : array(); | |
| $include_terms = isset( $tax_query_input['include'] ) && is_array( $tax_query_input['include'] ) | |
| ? $tax_query_input['include'] | |
| : array(); | |
| $exclude_terms = isset( $tax_query_input['exclude'] ) && is_array( $tax_query_input['exclude'] ) | |
| ? $tax_query_input['exclude'] | |
| : array(); | |
| $include_terms = isset( $tax_query_input['include'] ) && is_array( $tax_query_input['include'] ) | |
| ? $tax_query_input['include'] | |
| : array(); |
| $tax_query = array(); | ||
| // If there are keys other than include/exclude, it's the old | ||
| // format e.g. "taxQuery":{"category":[4]} | ||
| if ( ! empty( array_diff( array_keys( $tax_query_input ), array( 'include', 'exclude' ) ) ) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically someone could have a taxonomy named include or exclude, no?
Trac ticket: https://core.trac.wordpress.org/ticket/64416
In GB we've updated the structure of Query Loop's taxQuery to also handle exclusion of terms in this PR (WordPress/gutenberg#73790).
The new structure is:
We need to update build_query_vars_from_query_block to handle this new taxQuery structure.
Testing instructions
Since this change should be handling Query Loop structure for 7.0 after the packages sync, we can test by:
Query Loop(through inspector controls) and add ataxonomy:categoryfilter with your created category.taxQuerystructure. Make sure to update thecategory idfrom the snippet, with the category id you've created. This refers to the"taxQuery":{"include":{"category":[3]}}part, where you should probably need to update the3.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.