Skip animations with non-default parameters for v3.0#291
Skip animations with non-default parameters for v3.0#291camillobruni merged 5 commits intoWebKit:JetStream3.0from
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
camillobruni
changed the title
danleh
left a comment
danleh
left a comment
There was a problem hiding this comment.
LGTM, but wouldn't we also want to disable animations for the full suite via an additional parameter?
|
For now this is probably good enough since you can disable it with "&startAutomtically" which we can use in our infra. |
danleh
left a comment
danleh
left a comment
There was a problem hiding this comment.
Still LGTM, but let's have a look by Keith whether this would be fine for 3.0.
kmiller68
left a comment
kmiller68
left a comment
There was a problem hiding this comment.
LGTM, have you had a chance to confirm on your end that it doesn't change the scores? My local testing of Safari in our harness was neutral.
|
On chrome running on the local server I see no diff with the default params: |
3 participants
We don't want CSS animation to interfere with short running measurements which
can easaily happen if you only run a single workload.