Add and use readLE/writeLE helpers#8470
Open
sertonix wants to merge 1 commit intoWebAssembly:mainfrom
Open
Conversation
According to godbolt.org these functions optimize to a simple *(T *)ptr in many cases while ensuring that memory alignment requirements and endianess does not effect the behavior. The unroll pragma seems to unfortunately be needed for gcc and clang to correctly optimize uint32_t and larger types. The approach of using bit shifts is also used in multiple other parts of binaryen (eg. WasmBinaryReader::getInt16) but usage of the helper function doesn't seem to be that easy there. Unfortunately std::array and uint8_t required some special casing in the templates :( Ref WebAssembly#2983
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to godbolt.org these functions optimize to a simple
*(T *)ptrin many cases while ensuring that memory alignment requirements and endianess does not effect the behavior.The unroll pragma seems to unfortunately be needed for gcc and clang to correctly optimize
uint32_tand larger types.The approach of using bit shifts is also used in multiple other parts of binaryen (eg.
WasmBinaryReader::getInt16) but usage of the helper function doesn't seem to be that easy there.Unfortunately
std::arrayanduint8_trequired some special casing in the templates :(Ref #2983